fix(extension): remove stranded matchPullRequestTarget (#8023) by andriypolanski · Pull Request #8032 · JSONbored/loopover

andriypolanski · 2026-07-22T14:01:04Z

Summary

#7487 removed issue-page matching from matchGitHubPageTarget but left matchPullRequestTarget as an unused duplicate (only re-exported via __loopoverContentInternals).
Deleted the dead helper and its test-hook export; kept the same route coverage in test/unit/extension-content.test.ts via matchGitHubPageTarget.

Closes #8023

Scope

The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

If any required check was skipped, explain why:

Dead-code removal only. Ran npx vitest run test/unit/extension-content.test.ts, npm run extension:lint, and npm run extension:typecheck. No production behavior change; apps/** is not graded by Codecov patch.

Safety

No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
API/OpenAPI/MCP behavior is updated and tested where needed.
UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — dead-code removal in the extension content script; no visible UI change.

Notes

Confirmed no remaining production references to matchPullRequestTarget (only previously in content.js + the root unit test, now updated).

JSONbored#7487 left a duplicate of matchGitHubPageTarget with no production callers; drop it and the unused test-internals export. Co-authored-by: Cursor <cursoragent@cursor.com>

superagent-security · 2026-07-22T14:02:32Z

Superagent didn't find any vulnerabilities or security issues in this PR.

loopover-orb · 2026-07-22T14:06:33Z

Caution

🛑 LoopOver review result - fixes required

_{Review updated: 2026-07-22 14:07:01 UTC}

2 files · 1 AI reviewer · no blockers · CI failing · unknown

🛑 Suggested Action - Fix Blockers

Review summary
This PR removes the unused matchPullRequestTarget helper from apps/loopover-extension/content.js and its test-hook export, updating the test suite to cover the same nested-path behavior (e.g. /pull/146/files) through matchGitHubPageTarget instead. The change is a straightforward, correct dead-code removal — matchGitHubPageTarget already produces the equivalent shape (owner/repo/pullNumber), so no behavior is lost, and the diff traces cleanly to the stated issue (#8023) which is itself linked from #7487's earlier removal of issue-page matching. Test coverage of the removed function's call sites is preserved, just re-pointed at the surviving function.

Nits — 2 non-blocking

The four FAILED validate-tests/validate checks are marked '(no detail provided)', so their cause can't be confirmed from what's given here — worth checking whether they're a pre-existing flake or actually related to this diff before merging.
Consider a one-line comment near matchGitHubPageTarget noting it now serves both the mount call and the former PR-target use case, so a future refactor doesn't reintroduce a duplicate wrapper.

CI checks failing

validate
validate-tests (2)
validate-tests (1)
validate-tests (3)

Decision drivers

✅ Code review — No blockers (1 reviewer)
✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8023
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 203 registered-repo PR(s), 128 merged, 22 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	andriypolanski; Gittensor profile; 203 PR(s), 22 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: minor

Linked issue satisfaction

Addressed
The diff removes matchPullRequestTarget from content.js and its export from __loopoverContentInternals, and updates the test file to rely solely on matchGitHubPageTarget for equivalent route coverage, matching both deliverables in the issue.

Review context

Author: andriypolanski
Role context: outside_contributor
Public audience mode: oss maintainer
Lane context: Repository is configured for direct PR review.
Public profile languages: Python, TypeScript, JavaScript, Rust, Cuda, Kotlin, MDX, Scala
Official Gittensor activity: 203 PR(s), 22 issue(s).
PR-specific overlap: none found.

Contributor next steps

Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

Related work = same linked issue, overlapping active PRs, or title/path similarity.
Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

@loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
@loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview

Route	Viewport	Before (production)	After (this PR's preview)	Diff
`/`	desktop	_{before /}	_{after /}	—
`/`	mobile	_{before / (mobile)}	_{after / (mobile)}	—

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

Scroll preview

Route	Before (production)	After (this PR's preview)
`/`	_{before / (scroll)}	_{after / (scroll)}

A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

Re-run LoopOver review

loopover-orb · 2026-07-22T14:07:08Z

LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests (2), validate-tests (1), validate-tests (3))). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

andriypolanski · 2026-07-22T15:42:11Z

Hi, @JSONbored
This pr needs manual review. please take a look.

fix(extension): remove stranded matchPullRequestTarget (JSONbored#8023)

5430065

JSONbored#7487 left a duplicate of matchGitHubPageTarget with no production callers; drop it and the unused test-internals export. Co-authored-by: Cursor <cursoragent@cursor.com>

andriypolanski requested a review from JSONbored as a code owner July 22, 2026 14:01

loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 22, 2026

loopover-orb Bot assigned andriypolanski Jul 22, 2026

loopover-orb Bot closed this Jul 22, 2026

milosde111 mentioned this pull request Jul 22, 2026

fix(extension): remove stranded matchPullRequestTarget and keep scoped CI coverage (#8023) #8062

Merged

24 tasks

Navigation Menu

Uh oh!

fix(extension): remove stranded matchPullRequestTarget (#8023) - #8032

fix(extension): remove stranded matchPullRequestTarget (#8023)#8032
andriypolanski wants to merge 1 commit into
JSONbored:mainfrom
andriypolanski:fix/8023-remove-match-pull-request-target

andriypolanski commented Jul 22, 2026

Uh oh!

superagent-security Bot commented Jul 22, 2026

Uh oh!

loopover-orb Bot commented Jul 22, 2026 •

edited

Loading

🛑 LoopOver review result - fixes required

Uh oh!

loopover-orb Bot commented Jul 22, 2026

Uh oh!

andriypolanski commented Jul 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

andriypolanski commented Jul 22, 2026

Summary

Scope

Validation

Safety

UI Evidence

Notes

Uh oh!

superagent-security Bot commented Jul 22, 2026

Uh oh!

loopover-orb Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛑 LoopOver review result - fixes required

Uh oh!

loopover-orb Bot commented Jul 22, 2026

Uh oh!

andriypolanski commented Jul 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

loopover-orb Bot commented Jul 22, 2026 •

edited

Loading